Re: [RFT PATCH 1/3] ARM: dts: exynos: add "gpios" suffix to wlf,ldo1ena on Midas

From: Henrik Grimler
Date: Thu Feb 09 2023 - 02:18:18 EST


On Wed, Feb 08, 2023 at 06:26:32PM +0100, Krzysztof Kozlowski wrote:
> The GPIOs properties should end with "gpios" suffix and Linux gpiolib
> already handles both names, so switch to preferred one.
>
> While touching the lines, replace open-coded GPIO_ACTIVE_HIGH flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Tested-by: Henrik Grimler <henrik@xxxxxxxxxx>

Audio still works fine on i9300, and there are no new warnings/errors
in dmesg.

Best regards,
Henrik Grimler

> ---
> arch/arm/boot/dts/exynos4412-midas.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index d5074fa57142..525f945c4b91 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -653,8 +653,8 @@ wm1811: audio-codec@1a {
> CPVDD-supply = <&vbatt_reg>;
> SPKVDD1-supply = <&vbatt_reg>;
> SPKVDD2-supply = <&vbatt_reg>;
> - wlf,ldo1ena = <&gpj0 4 0>;
> - wlf,ldo2ena = <&gpj0 4 0>;
> + wlf,ldo1ena-gpios = <&gpj0 4 GPIO_ACTIVE_HIGH>;
> + wlf,ldo2ena-gpios = <&gpj0 4 GPIO_ACTIVE_HIGH>;
> };
> };
>
> --
> 2.34.1
>