Re: [PATCH] erofs: make kobj_type structures constant

[Gao Xiang]

On 2023/2/9 11:21, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Acked-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Thanks,
Gao Xiang

> ---
>   fs/erofs/sysfs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/erofs/sysfs.c b/fs/erofs/sysfs.c
> index fd476961f742..435e515c0792 100644
> --- a/fs/erofs/sysfs.c
> +++ b/fs/erofs/sysfs.c
> @@ -179,13 +179,13 @@ static const struct sysfs_ops erofs_attr_ops = {
>   	.store	= erofs_attr_store,
>   };
>   
> -static struct kobj_type erofs_sb_ktype = {
> +static const struct kobj_type erofs_sb_ktype = {
>   	.default_groups = erofs_groups,
>   	.sysfs_ops	= &erofs_attr_ops,
>   	.release	= erofs_sb_release,
>   };
>   
> -static struct kobj_type erofs_ktype = {
> +static const struct kobj_type erofs_ktype = {
>   	.sysfs_ops	= &erofs_attr_ops,
>   };
>   
> @@ -193,7 +193,7 @@ static struct kset erofs_root = {
>   	.kobj	= {.ktype = &erofs_ktype},
>   };
>   
> -static struct kobj_type erofs_feat_ktype = {
> +static const struct kobj_type erofs_feat_ktype = {
>   	.default_groups = erofs_feat_groups,
>   	.sysfs_ops	= &erofs_attr_ops,
>   };
>
> ---
> base-commit: 0983f6bf2bfc0789b51ddf7315f644ff4da50acb
> change-id: 20230209-kobj_type-erofs-0f0f4c901045
>
> Best regards,