fs/nfs/fscache.c:58:51: sparse: sparse: incorrect type in argument 3 (different base types)

From: kernel test robot
Date: Wed Feb 08 2023 - 17:06:24 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0983f6bf2bfc0789b51ddf7315f644ff4da50acb
commit: a6b5a28eb56c3f4988f7ff5290b954ba296e309a nfs: Convert to new fscache volume/cookie API
date: 1 year, 1 month ago
config: arm64-randconfig-s043-20230208 (https://download.01.org/0day-ci/archive/20230209/202302090655.5qEJavZm-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a6b5a28eb56c3f4988f7ff5290b954ba296e309a
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a6b5a28eb56c3f4988f7ff5290b954ba296e309a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/infiniband/hw/hns/ drivers/remoteproc/ fs/nfs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202302090655.5qEJavZm-lkp@xxxxxxxxx

sparse warnings: (new ones prefixed by >>)
>> fs/nfs/fscache.c:58:51: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be16 const [usertype] sin_port @@
fs/nfs/fscache.c:58:51: sparse: expected unsigned long long x
fs/nfs/fscache.c:58:51: sparse: got restricted __be16 const [usertype] sin_port
>> fs/nfs/fscache.c:59:61: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be32 const [usertype] s_addr @@
fs/nfs/fscache.c:59:61: sparse: expected unsigned long long x
fs/nfs/fscache.c:59:61: sparse: got restricted __be32 const [usertype] s_addr
>> fs/nfs/fscache.c:64:52: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be16 const [usertype] sin6_port @@
fs/nfs/fscache.c:64:52: sparse: expected unsigned long long x
fs/nfs/fscache.c:64:52: sparse: got restricted __be16 const [usertype] sin6_port
>> fs/nfs/fscache.c:65:73: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be32 const @@
fs/nfs/fscache.c:65:73: sparse: expected unsigned long long x
fs/nfs/fscache.c:65:73: sparse: got restricted __be32 const
fs/nfs/fscache.c:66:73: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be32 const @@
fs/nfs/fscache.c:66:73: sparse: expected unsigned long long x
fs/nfs/fscache.c:66:73: sparse: got restricted __be32 const
fs/nfs/fscache.c:67:73: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be32 const @@
fs/nfs/fscache.c:67:73: sparse: expected unsigned long long x
fs/nfs/fscache.c:67:73: sparse: got restricted __be32 const
fs/nfs/fscache.c:68:73: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long long x @@ got restricted __be32 const @@
fs/nfs/fscache.c:68:73: sparse: expected unsigned long long x
fs/nfs/fscache.c:68:73: sparse: got restricted __be32 const

vim +58 fs/nfs/fscache.c

37
38 /*
39 * Get the per-client index cookie for an NFS client if the appropriate mount
40 * flag was set
41 * - We always try and get an index cookie for the client, but get filehandle
42 * cookies on a per-superblock basis, depending on the mount flags
43 */
44 static bool nfs_fscache_get_client_key(struct nfs_client *clp,
45 char *key, int *_len)
46 {
47 const struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *) &clp->cl_addr;
48 const struct sockaddr_in *sin = (struct sockaddr_in *) &clp->cl_addr;
49
50 *_len += snprintf(key + *_len, NFS_MAX_KEY_LEN - *_len,
51 ",%u.%u,%x",
52 clp->rpc_ops->version,
53 clp->cl_minorversion,
54 clp->cl_addr.ss_family);
55
56 switch (clp->cl_addr.ss_family) {
57 case AF_INET:
> 58 if (!nfs_append_int(key, _len, sin->sin_port) ||
> 59 !nfs_append_int(key, _len, sin->sin_addr.s_addr))
60 return false;
61 return true;
62
63 case AF_INET6:
> 64 if (!nfs_append_int(key, _len, sin6->sin6_port) ||
> 65 !nfs_append_int(key, _len, sin6->sin6_addr.s6_addr32[0]) ||
66 !nfs_append_int(key, _len, sin6->sin6_addr.s6_addr32[1]) ||
67 !nfs_append_int(key, _len, sin6->sin6_addr.s6_addr32[2]) ||
68 !nfs_append_int(key, _len, sin6->sin6_addr.s6_addr32[3]))
69 return false;
70 return true;
71
72 default:
73 printk(KERN_WARNING "NFS: Unknown network family '%d'\n",
74 clp->cl_addr.ss_family);
75 return false;
76 }
77 }
78

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests