Re: [PATCH v2 2/2] sample: rust: print: Add sampe code for Arc printing

From: Boqun Feng
Date: Wed Feb 08 2023 - 11:59:24 EST


On Wed, Feb 08, 2023 at 05:56:43PM +0100, Miguel Ojeda wrote:
> On Wed, Feb 8, 2023 at 5:34 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
> >
> > Hmm.. I'm OK with this change, but it's not a typo ;-)
>
> By typo I meant the "sampe", not the other changes -- sorry, I should
> have been more clear.

Ah, good eyes! Sorry I missed that twice: one when submitting and one
you mention it's a typo ;-(


Regards,
Boqun

>
> > 1) capitalize the first letter after subsystem tags in the title
> > since that's kinda the rule for a few subsystems I usually work
> > on, I don't have my own preference, just something I'm used to
> > ;-)
>
> Yeah, I don't mind one way or the other (in fact, personally I prefer
> uppercase slightly because it is a bit easier to "scan" visually to
> see where it starts after the prefixes). The lowercase one is just the
> one we have used so far for Rust (which I picked looking at what Linus
> et al. usually do).
>
> > 2) avoid using "`" in the title to save space because title space
> > is precious.
>
> I see, makes sense, thanks!
>
> Cheers,
> Miguel