Re: [PATCH 1/1] ice: Change assigning method of the CPU affinity masks

From: Andy Shevchenko
Date: Wed Feb 08 2023 - 11:08:51 EST


On Wed, Feb 08, 2023 at 09:18:14PM +0530, Kalesh Anakkur Purayil wrote:
> On Wed, Feb 8, 2023 at 9:11 PM Pawel Chmielewski <
> pawel.chmielewski@xxxxxxxxx> wrote:

...

> > + u16 v_idx, cpu = 0;
> >
> [Kalesh]: if you initialize v_idx to 0 here, you can avoid the assignment
> below

I would avoid doing this.

The problem is that it will become harder to maintain and more error prone
during development.

So, please leave as is.

--
With Best Regards,
Andy Shevchenko