Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

[Suren Baghdasaryan]

On Tue, Jan 31, 2023 at 3:12 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 31 Jan 2023 13:08:19 -0800 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> > On Tue, Jan 31, 2023 at 12:54 PM Andrew Morton
> > <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
> > >
> > > > > > -             vma->vm_flags &= ~VM_MAYWRITE;
> > > > > > +             vm_flags_clear(vma, VM_MAYSHARE);
> > > > > >       }
> > > > >
> > > > > I think it should be:
> > > > >         s/VM_MAYSHARE/VM_MAYWRITE/
> > > >
> > >
> > > I added the fixup.  Much better than resending a seven patch series for a
> > > single line change.  Unless you have substantial other changes pending.
> >
> > Thanks! That sounds reasonable.
> >
> > I'll also need to introduce vm_flags_reset_once() to use in
> > replacement of WRITE_ONCE(vma->vm_flags, newflags) case. Should I send
> > a separate short patch for that?
>
> That depends on what the patch looks like.  How about you send it
> and we'll see?

Here it is: https://lore.kernel.org/all/20230201000116.1333160-1-surenb@xxxxxxxxxx/

>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxx.
>