Re: [PATCH v2 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support
From: Krzysztof Kozlowski
Date: Tue Jan 31 2023 - 14:05:20 EST
On 30/01/2023 19:05, Neeraj Sanjay Kale wrote:
> Add binding document for generic and legacy NXP bluetooth
> chipsets.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>
> ---
> v2: Resolved dt_binding_check errors. (Rob Herring)
> v2: Modified description, added specific compatibility devices,
> corrected indentations. (Krzysztof Kozlowski)
> ---
> .../bindings/net/bluetooth/nxp-bluetooth.yaml | 40 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
> new file mode 100644
> index 000000000000..9c8a25396b49
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
Filename based on family of devices or compatible (assuming it is
correct): nxp,w8987-bt.yaml
Hyphen is not a correct separator between vendor prefix and device name.
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth/nxp-bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP Bluetooth chips
> +
> +description:
> + This binding describes UART-attached NXP bluetooth chips.
This is description of binding. So in description of binding for NXP
bluetooth chips you say that it describes NXP bluetooth chips. I don't
think it's useful. Describe the hardware instead.
> +
> +maintainers:
> + - Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,w8987-bt
> + - nxp,w8997-bt
> + - nxp,w9098-bt
> + - nxp,iw416-bt
> + - nxp,iw612-bt
Why "bt" suffix? Are these chips coming with other functions?
Best regards,
Krzysztof