Re: [PATCH net-next 3/5] drivers: net: dsa: add fdb entry flags incoming to switchcore drivers

[Simon Horman]

On Mon, Jan 30, 2023 at 06:34:27PM +0100, Hans J. Schultz wrote:
> Ignore FDB entries with set flags coming in on all switchcore drivers.
> 
> Signed-off-by: Hans J. Schultz <netdev@xxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/dsa/b53/b53_common.c       | 12 ++++++++++--
>  drivers/net/dsa/b53/b53_priv.h         |  4 ++--
>  drivers/net/dsa/hirschmann/hellcreek.c | 12 ++++++++++--
>  drivers/net/dsa/lan9303-core.c         | 12 ++++++++++--
>  drivers/net/dsa/lantiq_gswip.c         | 12 ++++++++++--
>  drivers/net/dsa/microchip/ksz9477.c    |  8 ++++----
>  drivers/net/dsa/microchip/ksz9477.h    |  8 ++++----
>  drivers/net/dsa/microchip/ksz_common.c | 14 +++++++++++---
>  drivers/net/dsa/mt7530.c               | 12 ++++++++++--
>  drivers/net/dsa/mv88e6xxx/chip.c       | 12 ++++++++++--
>  drivers/net/dsa/ocelot/felix.c         | 12 ++++++++++--
>  drivers/net/dsa/qca/qca8k-common.c     | 12 ++++++++++--
>  drivers/net/dsa/qca/qca8k.h            |  4 ++--
>  drivers/net/dsa/rzn1_a5psw.c           | 12 ++++++++++--
>  drivers/net/dsa/sja1105/sja1105_main.c | 19 ++++++++++++++-----
>  include/net/dsa.h                      |  4 ++--
>  net/dsa/switch.c                       | 12 ++++++++----
>  17 files changed, 137 insertions(+), 44 deletions(-)
> 
> diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
> index 59cdfc51ce06..cec60af6dfdc 100644
> --- a/drivers/net/dsa/b53/b53_common.c
> +++ b/drivers/net/dsa/b53/b53_common.c
> @@ -1684,11 +1684,15 @@ static int b53_arl_op(struct b53_device *dev, int op, int port,
>  
>  int b53_fdb_add(struct dsa_switch *ds, int port,
>  		const unsigned char *addr, u16 vid,
> -		struct dsa_db db)
> +		u16 fdb_flags, struct dsa_db db)
>  {
>  	struct b53_device *priv = ds->priv;
>  	int ret;
>  
> +	/* Ignore entries with set flags */
> +	if (fdb_flags)
> +		return 0;


	Would returning -EOPNOTSUPP be more appropriate?

...