Re: [PATCH RESEND 0/5] Fix UPI uncore issue on SPR

From: Steve Wahl
Date: Tue Jan 31 2023 - 12:19:27 EST


I reviewed this patch series, applied it to a kernel tree, and tested
it on two larger (12+ socket) systems, did not notice any adverse
affects. So I believe it's appropriate to add both of these tags:

Tested-by: Steve Wahl <steve.wahl@xxxxxxx>
Reviewed-by: Steve Wahl <steve.wahl@xxxxxxx>

--> Steve

On Thu, Jan 12, 2023 at 12:01:00PM -0800, kan.liang@xxxxxxxxxxxxxxx wrote:
> From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>
> The discovery table of UPI on SPR MCC is broken. The patch series is
> to mitigate the issue by providing a hardcode pre-defined table.
>
> The broken discovery table can trigger a kernel warning message, which
> is overkilled. The patch series also refine the error handling code.
>
> Kan Liang (5):
> perf/x86/uncore: Factor out uncore_device_to_die()
> perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name
> perf/x86/uncore: Ignore broken units in discovery table
> perf/x86/uncore: Add a quirk for UPI on SPR
> perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table
>
> arch/x86/events/intel/uncore.c | 34 ++++-
> arch/x86/events/intel/uncore.h | 4 +
> arch/x86/events/intel/uncore_discovery.c | 60 ++++++---
> arch/x86/events/intel/uncore_discovery.h | 14 +-
> arch/x86/events/intel/uncore_snbep.c | 158 ++++++++++++++++++-----
> 5 files changed, 210 insertions(+), 60 deletions(-)
>
> --
> 2.35.1
>

--
Steve Wahl, Hewlett Packard Enterprise