Re: [PATCH] ipv6: ICMPV6: Use swap() instead of open coding it

From: David Ahern
Date: Tue Jan 31 2023 - 11:03:13 EST


On 1/30/23 11:34 PM, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
>
> ./net/ipv6/icmp.c:344:25-26: WARNING opportunity for swap().
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3896
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> net/ipv6/icmp.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>

Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>