Re: [PATCH 3/3] gpio: mmio: Use new flag BGPIOF_NO_INPUT

[Leonard, Niall]

On 29/01/2023 16:01, Krzysztof Kozlowski wrote:
> *External Message* - Use caution before opening links or attachments
> 
> On 26/01/2023 11:17, Niall Leonard via B4 Submission Endpoint wrote:
>> From: Niall Leonard <nl250060@xxxxxxx>
>>
>> Use the existing shadow data register 'bgpio_data' to allow
>> the last written value to be returned by the read operation
>> when BGPIOF_NO_INPUT flag is set.
>>
> 
> (...)
> 
>>   	if (gc->set == bgpio_set_set &&
>>   			!(flags & BGPIOF_UNREADABLE_REG_SET))
>>   		gc->bgpio_data = gc->read_reg(gc->reg_set);
>> @@ -711,6 +723,9 @@ static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
>>   	if (of_property_read_bool(pdev->dev.of_node, "no-output"))
>>   		*flags |= BGPIOF_NO_OUTPUT;
>>   
>> +	if (of_property_read_bool(pdev->dev.of_node, "no-input"))
> 
> As pointed, this brings undocumented property to two other bindings.
> This needs to be fixed.
> 
> Best regards,
> Krzysztof
> 
Thanks for reviewing.
I will update the other 2 bindings in the next version.

Regards,
Niall Leonard