Re: [PATCH] tty:pty: move wake_up*() after tty_vhangup() in pty_close()

From: Greg KH
Date: Tue Jan 31 2023 - 04:56:49 EST


On Fri, Jan 27, 2023 at 03:20:17PM +0800, Yan Cangang wrote:
> wake_up_interruptible() may wake up the session leader blocked on pts, at
> this time the tty_signal_session_leader() in __tty_hangup() has not been
> executed.
>
> The session leader's subsequent IO on pts will fail, but the session
> leader did not received SIGHUP as expected at this time.
>
> A observed phenomenon is that when the ssh connection is disconnected, the
> background jobs managed by bash did not terminate as expected. This
> problem is more easily observed on low-end single-processor systems.

This feels odd, why is this only showing up now? What changed to cause
this issue?

What commit id does this fix?

thanks,

greg k-h