Re: [PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()

From: Huang, Ying
Date: Tue Jan 31 2023 - 02:28:41 EST


Longlong Xia <xialonglong1@xxxxxxxxxx> writes:

> It's known that get_swap_pages() may fail to find available space
> under some extreme case, but pr_debug() provides useless information.
> Let's remove it.
>
> Signed-off-by: Longlong Xia <xialonglong1@xxxxxxxxxx>

Thanks!

Reviewed-by: "Huang, Ying" <ying.huang@xxxxxxxxx>

> ---
> mm/swapfile.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 6202a6668a63..99143875d6f0 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -1098,8 +1098,6 @@ int get_swap_pages(int n_goal, swp_entry_t swp_entries[], int entry_size)
> spin_unlock(&si->lock);
> if (n_ret || size == SWAPFILE_CLUSTER)
> goto check_out;
> - pr_debug("scan_swap_map of si %d failed to find offset\n",
> - si->type);
> cond_resched();
>
> spin_lock(&swap_avail_lock);