Re: [PATCH v6 4/6] clk: qcom: lpasscorecc-sc7280: Skip lpasscorecc registration

From: Srinivasa Rao Mandadapu
Date: Tue Jan 31 2023 - 01:35:30 EST



On 1/31/2023 6:24 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
Quoting Srinivasa Rao Mandadapu (2023-01-26 02:14:23)
Skip lpasscorecc clocks registration for ADSP based platforms
as it's causing NOC errors when ADSP based clocks are enabled.

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
Tested-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
---
drivers/clk/qcom/lpasscorecc-sc7280.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/clk/qcom/lpasscorecc-sc7280.c b/drivers/clk/qcom/lpasscorecc-sc7280.c
index 6ad19b0..3aa16d8 100644
--- a/drivers/clk/qcom/lpasscorecc-sc7280.c
+++ b/drivers/clk/qcom/lpasscorecc-sc7280.c
@@ -395,6 +395,9 @@ static int lpass_core_cc_sc7280_probe(struct platform_device *pdev)
const struct qcom_cc_desc *desc;
struct regmap *regmap;

+ if (of_property_read_bool(pdev->dev.of_node, "qcom,adsp-pil-mode"))
Why is this node enabled in DT at all if it doesn't provide any clks?

Yes. Agree that we can disable this node in board specific DTS file. As I thought, disabling node is not appropriate,

preferred this way.
Anyway, as suggested, will drop this patch and disable node in DT.