Re: [PATCH 01/18] lib/stackdepot: fix setting next_slab_inited in init_stack_slab

From: Andrew Morton
Date: Mon Jan 30 2023 - 19:18:27 EST


On Mon, 30 Jan 2023 21:49:25 +0100 andrey.konovalov@xxxxxxxxx wrote:

> In commit 305e519ce48e ("lib/stackdepot.c: fix global out-of-bounds in
> stack_slabs"), init_stack_slab was changed to only use preallocated
> memory for the next slab if the slab number limit is not reached.
> However, setting next_slab_inited was not moved together with updating
> stack_slabs.
>
> Set next_slab_inited only if the preallocated memory was used for the
> next slab.

Please provide a full description of the user-visible runtime effects
of the bug (always always).

I'll add the cc:stable (per your comments in the [0/N] cover letter),
but it's more reliable to add it to the changelog yourself.

As to when I upstream this: don't know - that depends on the
user-visible-effects thing.