Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

From: Andy Shevchenko
Date: Mon Jan 30 2023 - 07:19:47 EST


On Sat, Jan 28, 2023 at 04:11:30PM +0800, ye.xingchen@xxxxxxxxxx wrote:
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

...

> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
> + keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

Why?

What we need here is simple devm_platform_ioremap_resource().

--
With Best Regards,
Andy Shevchenko