Re: [PATCH v8 5/5] input: pwm-beeper: handle module unloading properly

From: Frieder Schrempf
Date: Mon Jan 30 2023 - 04:07:16 EST


Hi Manuel,

On 26.01.23 10:18, Manuel Traut wrote:
> 'input: pwm-beeper: add feature to set volume via sysfs' adds device
> attributes without removing them on error or if the module is unloaded.
>
> If the module will be unloaded and loaded again it fails:
> [ 1007.918180] sysfs: cannot create duplicate filename '/devices/platform/buzzer/volume'
>
> Therefore remove device attributes on module unloading and in case
> registration at the input subsystem fails.
>
> Signed-off-by: Manuel Traut <manuel.traut@xxxxxx>

Thanks for picking up these old patches!
I think you need to merge this fixup patch 5/5 into patch 2/5 of this
series.

Thanks
Frieder