Re: [PATCH v2 3/5] ASoC: amd: acp: Refactor i2s clocks programming sequence

[Venkata Prasad Potturu]

On 1/25/23 22:45, Pierre-Louis Bossart wrote:
Thanks for your time Louis.
> This patch adds new Sparse warnings [1]:
>
> sound/soc/amd/acp/acp-mach-common.c:189:35: error: restricted
> snd_pcm_format_t degrades to integer
> sound/soc/amd/acp/acp-mach-common.c:333:35: error: restricted
> snd_pcm_format_t degrades to integer
> sound/soc/amd/acp/acp-mach-common.c:478:35: error: restricted
> snd_pcm_format_t degrades to integer
> sound/soc/amd/acp/acp-mach-common.c:619:35: error: restricted
> snd_pcm_format_t degrades to integer
>
> > @@ -193,7 +163,11 @@ static int acp_card_rt5682_hw_params(struct snd_pcm_substream *substream,
> >   	struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
> >   	struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
> >   	int ret;
> > -	unsigned int fmt;
> > +	unsigned int fmt, srate, ch, format;
> > +
> > +	srate = params_rate(params);
> > +	ch = params_channels(params);
> > +	format = 8 * params_format(params);
> This last line looks suspicious, no? format-to-physical-size conversions
> should be using existing macros.
>
> Should it be
>
> format = params_physical_width(params);
>
> ?

Yes, we will use params_physical_width(params) and update it in the next 
patch.

Thanks for the information.

> > +	/* Set tdm/i2s1 master bclk ratio */
> > +	ret = snd_soc_dai_set_bclk_ratio(codec_dai, ch * format);
> > +	if (ret < 0) {
> > +		dev_err(rtd->dev, "Failed to set rt5682 tdm bclk ratio: %d\n", ret);
> > +		return ret;
> > +	}
> > +
> > +	if (!drvdata->soc_mclk) {
> > +		ret = acp_clk_enable(drvdata, srate, ch * format);
> > +		if (ret < 0) {
> > +			dev_err(rtd->card->dev, "Failed to enable HS clk: %d\n", ret);
> > +			return ret;
> > +		}
> [1]
> https://github.com/thesofproject/linux/actions/runs/4005001249/jobs/6874834205