RE: [PATCH v6 3/6] arm64: dts: Add i.MX8MQ PCIe EP support

From: Hongxing Zhu
Date: Sun Jan 29 2023 - 21:04:01 EST


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 2023年1月20日 16:09
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; Peng Fan
> <peng.fan@xxxxxxx>; marex@xxxxxxx; Marcel Ziswiler
> <marcel.ziswiler@xxxxxxxxxxx>; tharvey@xxxxxxxxxxxxx; Frank Li
> <frank.li@xxxxxxx>
> Cc: lorenzo.pieralisi@xxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH v6 3/6] arm64: dts: Add i.MX8MQ PCIe EP support
>
> On 20/01/2023 06:25, Richard Zhu wrote:
> > Add i.MX8MQ PCIe EP support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 32
> +++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 98fbba4c99a9..e1ffb7c9586d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -1605,6 +1605,38 @@ pcie1: pcie@33c00000 {
> > status = "disabled";
> > };
> >
> > + pcie1_ep: pcie_ep@33c00000 {
>
> Eh...
Would replace the underscore by hyphen.
Thanks.

Best Regards
Richard Zhu
>
> Best regards,
> Krzysztof