Re: [PATCH v3 0/5] A few bugfix and cleanup patches for sbitmap

From: Kemeng Shi
Date: Sun Jan 29 2023 - 20:16:19 EST



Hi Jens. Could you apply this patchset and the patchset "[PATCH v4 0/8]
A few bugfix and cleancode patch for bfq" sent on the same day.

on 1/17/2023 4:50 AM, Kemeng Shi wrote:
> Hi, this series contain a bugfix patch to correct wake_batch
> recalculation to avoid potential IO hung and a few cleanup patches to
> remove unnecessary check and repeat code in sbitmap. Thanks.
>
> ---
> v3:
> -Thank Jan for review. Collect Reviewed-by from Jan for all patches.
> -some cleanups according to recommends from Jan:
> 1)Add Fixes tag in patch 2/5 "sbitmap: remove redundant check in
> __sbitmap_queue_get_batch"
> 2)Avoid lines over 80 characters in patch 3/5 "sbitmap: rewrite
> sbitmap_find_bit_in_index to reduce repeat code"
> 3)Remove pointless line in patch 4/5 "sbitmap: add sbitmap_find_bit
> to remove repeat code in __sbitmap_get/__sbitmap_get_shallow"
>
> ---
> v2:
> -add patch "sbitmap: correct wake_batch recalculation to avoid potential
> IO hung"
> ---
>
> Kemeng Shi (5):
> sbitmap: remove unnecessary calculation of alloc_hint in
> __sbitmap_get_shallow
> sbitmap: remove redundant check in __sbitmap_queue_get_batch
> sbitmap: rewrite sbitmap_find_bit_in_index to reduce repeat code
> sbitmap: add sbitmap_find_bit to remove repeat code in
> __sbitmap_get/__sbitmap_get_shallow
> sbitmap: correct wake_batch recalculation to avoid potential IO hung
>
> lib/sbitmap.c | 102 ++++++++++++++++++++++----------------------------
> 1 file changed, 45 insertions(+), 57 deletions(-)
>

--
Best wishes
Kemeng Shi