Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

[Paul Cercueil]

Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
écrit :
> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
> Seems as if it was hidden and not noticed during testing since
> there is no sound DT node.
> 
> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
> SoCs and boards.")
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>

I missed it, but every time you have a Fixes: tag, you also need to add
below:
Cc: stable@xxxxxxxxxxxxxxx

unless the bug you fix is in one of the RCs (and not in a released
kernel).

I think you should send a V2 with this tag (and my ACK).

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 9819abb2465dd..a276488c0f752 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>                 regulator-min-microvolt = <5000000>;
>                 regulator-max-microvolt = <5000000>;
>  
> -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
> +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>                 enable-active-high;
>         };
>  };