Re: [PATCH] dt-bindings: display: bridge: sil,sii8620: convert to dtschema

[Krzysztof Kozlowski]

On 28/01/2023 09:30, Laurent Pinchart wrote:
> Hi Krzysztof,
> 
> Thank you for the patch.
> 
> On Fri, Jan 27, 2023 at 09:35:25PM +0100, Krzysztof Kozlowski wrote:
>> Convert the Silicon Image SiI8620 HDMI/MHL bridge bindings to DT schema.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>  .../bindings/display/bridge/sil,sii8620.yaml  | 107 ++++++++++++++++++
>>  .../bindings/display/bridge/sil-sii8620.txt   |  33 ------
>>  2 files changed, 107 insertions(+), 33 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/display/bridge/sil-sii8620.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
>> new file mode 100644
>> index 000000000000..90532bb99161
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii8620.yaml
>> @@ -0,0 +1,107 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/sil,sii8620.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Silicon Image SiI8620 HDMI/MHL bridge
>> +
>> +maintainers:
>> +  - Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> +
>> +properties:
>> +  compatible:
>> +    const: sil,sii8620
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    items:
>> +      - const: xtal
>> +
>> +  cvcc10-supply:
>> +    description: Digital Core Supply Voltage (1.0V)
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  iovcc18-supply:
>> +    description: I/O Supply Voltage (1.8V)
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    unevaluatedProperties: false
>> +
>> +    properties:
>> +      port@0:
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description:
>> +          Video port for HDMI (encoder) input
>> +
>> +      port@1:
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description:
>> +          MHL to connector port
>> +
>> +    required:
>> +      - port@0
> 
> Why port@0 only ?

I am not the author of the original binding, but when it was introduced,
I think it came without MHL port support - only HDMI. This probably is
incomplete but I guess can work due to some default settings. Shall we
make both required? I don't know, sounds reasonable...

Best regards,
Krzysztof