RE: [PATCH 11/11] ARM: dts: exynos: correct HSI2C properties in Exynos5410 Odroid XU

[Alim Akhtar]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, January 20, 2023 9:24 PM
> To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
> <alim.akhtar@xxxxxxxxxxx>; Inki Dae <inki.dae@xxxxxxxxxxx>; Kyungmin
> Park <kyungmin.park@xxxxxxxxxxx>; Kukjin Kim <kgene@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: replicant@xxxxxxxxxx; phone-devel@xxxxxxxxxxxxxxx;
> ~postmarketos/upstreaming@xxxxxxxxxxx; Martin Jücker
> <martin.juecker@xxxxxxxxx>; Henrik Grimler <henrik@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 11/11] ARM: dts: exynos: correct HSI2C properties in
> Exynos5410 Odroid XU
> 
> The HSI2C controller uses clock-frequency and does not have i2c-sda-delay.
> The properties were copy-pasted from the slower S3C-family I2C controller:
> 
>   exynos5410-odroidxu.dtb: i2c@12ca0000: Unevaluated properties are not
> allowed ('samsung,i2c-max-bus-freq', 'samsung,i2c-sda-delay' were
> unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index d1cbc6b8a570..232561620da2 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -164,8 +164,7 @@ map2 {
>  };
> 
>  &hsi2c_4 {
> -	samsung,i2c-sda-delay = <100>;
> -	samsung,i2c-max-bus-freq = <400000>;
> +	clock-frequency = <400000>;
>  	status = "okay";
> 
>  	usb3503: usb-hub@8 {
> --
> 2.34.1