Re: [PATCH 2/2] ipc,namespace: batch free ipc_namespace structures

From: Rik van Riel
Date: Fri Jan 27 2023 - 13:18:31 EST


On Fri, 2023-01-27 at 12:03 +0100, Giuseppe Scrivano wrote:
> Rik van Riel <riel@xxxxxxxxxxx> writes:
>
> >
> > +++ b/ipc/namespace.c
> > @@ -145,10 +145,11 @@ void free_ipcs(struct ipc_namespace *ns,
> > struct ipc_ids *ids,
> >  
> >  static void free_ipc_ns(struct ipc_namespace *ns)
> >  {
> > -       /* mq_put_mnt() waits for a grace period as kern_unmount()
> > -        * uses synchronize_rcu().
> > +       /*
> > +        * Caller needs to wait for an RCU grace period to have
> > passed
> > +        * after making the mount point inaccessible to new
> > accesses.
> >          */
> > -       mq_put_mnt(ns);
>
> mq_put_mnt() is not needed anymore, should it be removed?

Yes, indeed. Thank you!

I'll send a v3 of the series :)


--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part