Re: [PATCH v5 0/7] clk: qcom: msm8996: add APCS clock driver

From: Dmitry Baryshkov
Date: Fri Jan 27 2023 - 13:17:33 EST


On 27/01/2023 01:03, Dmitry Baryshkov wrote:
The sys_apcs_aux clock can be used by CPU and CBF clock drivers to drive
those clocks from GPLL0 while doing initial setup. Add simple driver to
setup and export this clock.

Jassi, please excuse me for this ping. Since the only questions are related to the clock driver (and hopefully they all are resolved), do you plan to merge the patches 1-6 for 6.3?


Changes since v4:
- Expand comments in the apcs-msm8996 driver describing the delay and
the reason for setting up the sys_apcs_aux clock as a fixed rate
rather than a fixed factor clock.

Changes since v3:
- Split the patch 3/6 into two: first one moves existing strings, second
one adds new compatible strings to the conditionals.

Changes since v2:
- Added the conditional clause to schema forbidding usage of clocks and
clock-names on platforms which do not pass additional clocks to the
APCS device node (Krzysztof)
- Added SDX55 compat string
- Moved MSM8976 compat to the list of platforms using syscon.

Changes since v1:
- Removed the clk.h header inclusion (Stephen)
- Changed the module license from GPL v2 to bare GPL.


Dmitry Baryshkov (7):
dt-bindings: mailbox: qcom: add SDX55 compatible
dt-bindings: mailbox: qcom: enable syscon compatible for msm8976
dt-bindings: mailbox: qcom: correct the list of platforms using clocks
dt-bindings: mailbox: qcom: add missing platforms to conditional
clauses
dt-bindings: mailbox: qcom: add #clock-cells to msm8996 example
mailbox: qcom-apcs-ipc: enable APCS clock device for MSM8996
clk: qcom: add the driver for the MSM8996 APCS clocks

.../mailbox/qcom,apcs-kpss-global.yaml | 37 ++++++--
drivers/clk/qcom/Makefile | 2 +-
drivers/clk/qcom/apcs-msm8996.c | 88 +++++++++++++++++++
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +-
4 files changed, 118 insertions(+), 11 deletions(-)
create mode 100644 drivers/clk/qcom/apcs-msm8996.c


--
With best wishes
Dmitry