RE: [PATCH 1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC

[Limonciello, Mario]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Friday, January 27, 2023 10:53
> To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>
> Cc: Jaroslav Kysela <jkysela@xxxxxxxxxx>; Mukunda, Vijendar
> <Vijendar.Mukunda@xxxxxxx>; Saba Kareem, Syed
> <Syed.SabaKareem@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> Pananchikkal, Renjith <Renjith.Pananchikkal@xxxxxxx>; Mark Pearson
> <mpearson@xxxxxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>;
> Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; alsa-
> devel@xxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC
> 
> On Fri, Jan 27, 2023 at 10:01:28AM -0600, Mario Limonciello wrote:
> > A number of users for Lenovo Rembrandt based laptops are
> > reporting that the microphone is too quiet relative to
> > Windows with a dual boot.
> >
> > Increase the PDM gain to overcome this problem.
> 
> Why not just make this a regular control that can be adjusted as
> users see fit?

Maximum HW gain is what we probably should have been setting from the
beginning.  The module parameter stuff was in case we need to debug it.

My thought is if we find some reported problems with the series we ask
users to try the module parameters.  If we're finding that certain parameters
make sense for different systems then we tear out the module parameter
and instead export a control and set policy from ucm.

If nothing is reported, we can probably drop the parameters at some time
in the future.