Re: [PATCH v2 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm
From: Krzysztof Kozlowski
Date: Fri Jan 27 2023 - 11:10:32 EST
On 27/01/2023 16:44, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Add DT bindings for the TLMM controller on sa8775p platforms.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
Thank you for your patch. There is something to discuss/improve.
> + reg:
> + maxItems: 1
> +
> + interrupts: true
> + interrupt-controller: true
> + "#interrupt-cells": true
> + gpio-controller: true
> + "#gpio-cells": true
> + gpio-ranges: true
Blank line here.
> + gpio-reserved-ranges:
> + minItems: 1
> + maxItems: 74
Blank line.
> + gpio-line-names:
> + maxItems: 148
Your GPIO pattern suggests you have 149 GPIOs. Something has to be
fixed. If this is 149, then reserved ranges is up to 75.
> +
> +required:
> + - compatible
> + - reg
> +
Best regards,
Krzysztof