Re: [PATCH 4/6] regulator: qcom_smd: Add PMIC compatible for IPQ9574

[Devi Priya]

On 1/18/2023 12:08 AM, Rob Herring wrote:
> On Fri, Jan 13, 2023 at 08:33:08PM +0530, devi priya wrote:
> > Add mp5496 PMIC compatible string for IPQ9574 SoC
> >
> > Co-developed-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml  | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
> > index 8c45f53212b1..7907d9385583 100644
> > --- a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
> > +++ b/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
> > @@ -22,7 +22,7 @@ description:
> >     Each sub-node is identified using the node's name, with valid values listed
> >     for each of the pmics below.
> >   
> > -  For mp5496, s2
> > +  For mp5496, s1, s2
> >   
> >     For pm2250, s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11,
> >     l12, l13, l14, l15, l16, l17, l18, l19, l20, l21, l22
> > @@ -84,6 +84,7 @@ properties:
> >     compatible:
> >       enum:
> >         - qcom,rpm-mp5496-regulators
> > +      - qcom,rpm-ipq9574-mp5496-regulators
>
> Is this a different part than just mp5496? Or used in a different,
> incompatible way?
IPQ6018 and IPQ9574 platforms use the same PMIC MP5496 but they have a 
different power layout.So, we plan to update the compatible: 
qcom,rpm-mp5496-regulators to 
qcom,rpm-ipq6018-mp5496-regulators(target-specific) in the next patchset 
as the regulators serve different purposes
> >         - qcom,rpm-pm2250-regulators
> >         - qcom,rpm-pm6125-regulators
> >         - qcom,rpm-pm660-regulators
> > --
> > 2.17.1
Best Regards,
Devi Priya