Re: [PATCH 02/12] crypto: axis - do not DMA to IV

From: Vincent Whitchurch
Date: Fri Jan 27 2023 - 10:39:36 EST


On Fri, Jan 20, 2023 at 10:11:51AM +0100, Herbert Xu wrote:
> On Tue, Jan 10, 2023 at 02:50:32PM +0100, Vincent Whitchurch wrote:
> > + unsigned char iv_bounce[AES_BLOCK_SIZE] CRYPTO_MINALIGN_ATTR;
>
> Please use the newly introduced CRYPTO_DMA_ALIGN macro.
>
> CRYPTO_MINALIGN only reflects minimum kmalloc alignment, which
> may be less than that required for DMA. You're currently safe
> on arm32, but we should not rely on this in new code.

Thanks, I'll fix this in v2. Should we add a CRYPTO_DMA_ALIGN_ATTR
macro similar to CRYPTO_MINALIGN_ATTR?