Re: [PATCH 05/11] arm64: dts: qcom: sc8280xp: align RPMh regulator nodes with bindings

From: Konrad Dybcio
Date: Fri Jan 27 2023 - 07:11:39 EST




On 27.01.2023 12:43, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 20c629172477..2f43b2fbc2a1 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -142,7 +142,7 @@ linux,cma {
> };
>
> &apps_rsc {
> - pmc8280-1-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "b";
>
> @@ -179,7 +179,7 @@ vreg_l6b: ldo6 {
> };
> };
>
> - pmc8280c-rpmh-regulators {
> + regulators-1 {
> compatible = "qcom,pm8350c-rpmh-regulators";
> qcom,pmic-id = "c";
>
> @@ -208,7 +208,7 @@ vreg_l13c: ldo13 {
> };
> };
>
> - pmc8280-2-rpmh-regulators {
> + regulators-2 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "d";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index b60185d9bdea..e41b630141fc 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -287,7 +287,7 @@ map1 {
> };
>
> &apps_rsc {
> - pmc8280-1-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "b";
>
> @@ -338,7 +338,7 @@ vreg_l6b: ldo6 {
> };
> };
>
> - pmc8280c-rpmh-regulators {
> + regulators-1 {
> compatible = "qcom,pm8350c-rpmh-regulators";
> qcom,pmic-id = "c";
> vdd-bob-supply = <&vreg_vph_pwr>;
> @@ -372,7 +372,7 @@ vreg_bob: bob {
> };
> };
>
> - pmc8280-2-rpmh-regulators {
> + regulators-2 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "d";
>