Re: [PATCH v9 24/27] dmaengine: dw-edma: Relax driver config settings

[Serge Semin]

On Thu, Jan 26, 2023 at 12:19:54PM -0600, Bjorn Helgaas wrote:
> On Thu, Jan 26, 2023 at 07:37:50PM +0300, Serge Semin wrote:
> > On Wed, Jan 25, 2023 at 05:23:57PM -0600, Bjorn Helgaas wrote:
> 
> > > It's a pretty trivial update, so I just did it myself.  The result is
> > > at https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/ctrl/dwc&id=ecadcaed4ef7
> > > 
> > > I split this patch and tweaked some commit messages for consistency
> > > (including the "DW eDMA PCIe driver" change above).  "git diff -b"
> > > with Lorenzo's current branch (95624672bb3e ("PCI: dwc: Add DW eDMA
> > > engine support")) is empty except for a minor comment change.  
> > 
> > Great! Thanks. Although I've already created v10 beforehand but didn't
> > submitted it yet waiting for your response. The split up patches look
> > exactly like yours.
> > 
> > In addition to that since I was going to re-send v10 I also took into
> > account your comments regarding the patch:
> > [PATCH v9 19/27] dmaengine: dw-edma: Use non-atomic io-64 methods
> > Link: https://lore.kernel.org/linux-pci/20230113171409.30470-20-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/
> > I've dropped unneeded modification and unpinned another fixes patch
> > which turned out to be a part of those modifications. So if you
> > re-based your pci/ctrl/dwc branch with that patch replaced with the
> > patches attached to this email it would have been great. Otherwise
> > it's ok to merge the series as is.
> > 
> > Note in the attached "non-atomic io-64" patch I've already replaced
> > the commit log with the your short version.
> 

> Awesome, thanks!  I folded those updates in and updated my branch.
> 
> And merged the whole thing into the PCI "next" branch.
> 
> Thanks for all your work!

Great! Thanks to you too with reviewing and helping to merge the bits.
I've almost completed another series with a few more updates based on
the notes made by you and Mani during the review. I'll submit the
patchset soon.

-Serge(y)

> 
> Bjorn