Re: [PATCH 5/8] gpiolib: remove legacy gpio_export

[Arnd Bergmann]

On Thu, Jan 26, 2023, at 15:00, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 02:27:58PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> There are only a handful of users of gpio_export() and
>> related functions.
>> 
>> As these are just wrappers around the modern gpiod_export()
>> helper, remove the wrappers and open-code the gpio_to_desc
>> in all callers to shrink the legacy API.
>
>
> A couple of comments below, after addressing:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>

Thanks!

>
>> -API参考
>
> Mistakenly removed?

Fixed now.

>>  
>>  	desc = gpio_to_desc(gpio);
>> -	/* reject bogus commands (gpio_unexport ignores them) */
>> +	/* reject bogus commands (gpiod_unexport ignores them) */
>
> While at it,
>
> 	/* reject bogus commands (gpiod_unexport() ignores them) */

Done,

    Arnd