Re: [PATCH v4 02/12] perf jevents metric: Add ability to rewrite metrics in terms of others

[John Garry]

On 26/01/2023 01:18, Ian Rogers wrote:
> Add RewriteMetricsInTermsOfOthers that iterates over pairs of names
> and expressions trying to replace an expression, within the current
> expression, with its name.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

hmmm ... did you test this for many python versions?

Maybe this patch causes this error:

Traceback (most recent call last):
 File "pmu-events/jevents.py", line 7, in <module>
   import metric
 File "/home/john/acme/tools/perf/pmu-events/metric.py", line 549, in 
<module>
   def RewriteMetricsInTermsOfOthers(metrics: list[Tuple[str, Expression]]
TypeError: 'type' object is not subscriptable
make[3]: *** [pmu-events/Build:26: pmu-events/pmu-events.c] Error 1
make[2]: *** [Makefile.perf:676: pmu-events/pmu-events-in.o] Error 2
make[2]: *** Waiting for unfinished jobs....

I have python 3.6.15

Thanks,
John