Re: [PATCH 1/2] mfd: Make .disable() callback return void

From: Uwe Kleine-König
Date: Thu Jan 26 2023 - 10:27:38 EST


Hello,

On Thu, Jan 26, 2023 at 01:34:16PM +0000, Lee Jones wrote:
> On Fri, 13 Jan 2023, Uwe Kleine-König wrote:
>
> > All implementations return 0 unconditionally, so change the prototype to
> > return void. This allows to get rid of error handling in callers that
> > isn't actually used.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> > drivers/mfd/asic3.c | 17 +++++++++--------
> > drivers/mfd/htc-pasic3.c | 3 +--
> > drivers/mfd/mfd-core.c | 4 +++-
> > drivers/mfd/t7l66xb.c | 4 +---
> > drivers/mfd/tc6387xb.c | 4 +---
> > drivers/mfd/tc6393xb.c | 16 ++++++++++------
> > include/linux/mfd/core.h | 2 +-
> > 7 files changed, 26 insertions(+), 24 deletions(-)
>
> Doesn't apply to the MFD tree.
>
> Please rebase and I'll merge it.

Oh, all the drivers that still provided the .enable() and .disable()
callbacks are gone now. So my patch series is superseeded by

http://lore.kernel.org/lkml/20230126152429.580539-1-u.kleine-koenig@xxxxxxxxxxxxxx

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature