Re: [PATCH 7/8] gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h

[Arnd Bergmann]

On Thu, Jan 26, 2023, at 15:08, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 02:28:00PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> This is a rarely used feature that has nothing to do with the
>> client-side of_gpio.h.
>> 
>> Split it out with a separate header file and Kconfig option
>> so it can be removed on its own timeline aside from removing
>> the of_gpio consumer interfaces.
>
> One nit-pick below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>

>>  
>> +config OF_GPIO_MM_GPIOCHIP
>> +	bool
>> +	help
>> +	  This adds support for the legacy 'struct of_mm_gpio_chip' interface
>> +	  from PowerPC. Existing drivers using this interface need to select
>> +	  this symbol, but new drivers should use the generic gpio-mmio
>
> gpio-regmap
>
> I would even not mention gpio-mmio.

Makes sense, thanks!

    Arnd