Re: [PATCH v9 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

From: Lee Jones
Date: Thu Jan 26 2023 - 09:36:59 EST


On Fri, 20 Jan 2023, Jianhua Lu wrote:

> Add support for Kinetic KTZ8866 backlight, which is used in
> Xiaomi tablet, Mi Pad 5 series. This driver lightly based on
> downstream implementation [1].
> [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c
>
> Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
> ---
> Changes in v2:
> - Add missing staitc modifier to ktz8866_write function.
>
> Changes in v3:
> - Add 2022 to Copyright line.
> - Sort headers.
> - Remove meaningless comment.
> - Use definitions instead of hardcoding.
> - Add missing maintainer info.
>
> Changes in v4:
> - Change 2022 to 2023.
> - Remove useless macro and enum.
> - Describe settings by devicetree.
> - Move header file to C file.
>
> Changes in v5:
> - Change "2023" to "2022, 2023" in Copyright line.
> - Set scale property for backlight.
>
> Changes in v6:
> - Correct devicetree property name.
>
> Changes in v7:
> - Remove unnecessary sleep statement.
> - Fix code style.
> - Add vddpos and vddneg supply devicetree parse.
> - Add enabel-gpio devicetree parse.
>
> Changes in v8:
> - Modify devicetree parse according to dt bindings.
>
> No changes in v9
>
> MAINTAINERS | 6 +
> drivers/video/backlight/Kconfig | 8 ++
> drivers/video/backlight/Makefile | 1 +
> drivers/video/backlight/ktz8866.c | 209 ++++++++++++++++++++++++++++++
> 4 files changed, 224 insertions(+)
> create mode 100644 drivers/video/backlight/ktz8866.c

Applied, thanks

--
Lee Jones [李琼斯]