Re: [PATCH 3/6] ARM: dts: exynos: add mmc aliases for Exynos4412

From: Krzysztof Kozlowski
Date: Thu Jan 26 2023 - 07:24:28 EST


On 26/01/2023 11:38, Henrik Grimler wrote:
> So that mmcblk numbering is fixed for the eMMC and sdcard, no matter
> if a storage device is attached or not. Also remove old, no longer
> used, mshc alias while we are at it.
>
> Signed-off-by: Henrik Grimler <henrik@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos4412.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> index 7b4e2c442888..9625e9fe63b1 100644
> --- a/arch/arm/boot/dts/exynos4412.dtsi
> +++ b/arch/arm/boot/dts/exynos4412.dtsi
> @@ -28,7 +28,10 @@ aliases {
> pinctrl3 = &pinctrl_3;
> fimc-lite0 = &fimc_lite_0;
> fimc-lite1 = &fimc_lite_1;
> - mshc0 = &mshc_0;
> + mmc0 = &mshc_0; /* eMMC */
> + mmc1 = &sdhci_1;
> + mmc2 = &sdhci_2; /* uSD */
> + mmc3 = &sdhci_3;

This is definitely not correct. Several boards do not have mmc1 or mmc2
exposed at all.

Best regards,
Krzysztof