Re: [PATCH v2 06/18] can: m_can: Disable unused interrupts

From: Simon Horman
Date: Thu Jan 26 2023 - 03:08:03 EST


On Wed, Jan 25, 2023 at 08:50:47PM +0100, Markus Schneider-Pargmann wrote:
> There are a number of interrupts that are not used by the driver at the
> moment. Disable all of these.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> ---
> drivers/net/can/m_can/m_can.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index a668a5836cf8..ef5ca5d37b0d 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1262,6 +1262,7 @@ static int m_can_chip_config(struct net_device *dev)
> {
> struct m_can_classdev *cdev = netdev_priv(dev);
> u32 cccr, test;
> + u32 interrupts = IR_ALL_INT;
> int err;

nit: reverse xmas tree (longest line to shortest line) for local variable
declarations.

...