Re: [PATCH 3/5] HID: dualsense_remove: manually unregister leds

From: Pietro Borrello
Date: Wed Jan 25 2023 - 20:01:54 EST


On Thu, 26 Jan 2023 at 01:44, Roderick Colenbrander
<thunderbird2k@xxxxxxxxx> wrote:
>
> Hi Pietro,
>
> Thanks for your patch. For sure for ds4/dualsense there have been edge
> cases around rumble removal and others. Those were prevented by this
> 'output_worker_initialized' variable, which is checked during the
> centralized work scheduling function (dualshock4_schedule_work /
> dualsense_schedule_work). That said I don't mind the change as it
> prevents the work scheduling functions to get called unnecessarily.

Hi Roderick,
Thank you for your fast response. You are right, the combination
of the `output_worker_initialized` variable and the spinlock prevents
the work to be scheduled during device removal for ds4/dualsense.
Thank you for the clarification!

Thanks,
Pietro