Re: [PATCH v5 1/9] dt-bindings: mfd: Add TI-Nspire misc registers

From: Rob Herring
Date: Wed Jan 25 2023 - 14:57:26 EST


On Mon, Jan 23, 2023 at 03:49:16PM -0600, Andrew Davis wrote:
> The TI Nspire devices contain a set of registers with a seemingly
> miscellaneous set of functionality. This area is known simply as the
> "misc" region.
>
> Signed-off-by: Andrew Davis <afd@xxxxxx>
> ---
> .../bindings/mfd/ti,nspire-misc.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,nspire-misc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,nspire-misc.yaml b/Documentation/devicetree/bindings/mfd/ti,nspire-misc.yaml
> new file mode 100644
> index 000000000000..316c4b3dcd87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,nspire-misc.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,nspire-misc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI Nspire MISC hardware block
> +
> +maintainers:
> + - Andrew Davis <afd@xxxxxx>
> +
> +description: |

Drop '|'

> + System controller node represents a register region containing a set
> + of miscellaneous registers. The registers are not cohesive enough to
> + represent as any specific type of device. Currently there is a reset
> + controller.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - ti,nspire-misc
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + reboot:
> + $ref: "../power/reset/syscon-reboot.yaml"

$ref: /schemas/power/reset/syscon-reboot.yaml#

Otherwise,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>