Re: [PATCH v1 2/3] ACPI: utils: Add acpi_get_first_match_physical_node()

From: Andy Shevchenko
Date: Wed Jan 25 2023 - 10:21:59 EST


On Mon, Jan 23, 2023 at 07:10:05PM +0200, Andy Shevchenko wrote:
> There are drivers that are using a logic that is combined in the offered
> acpi_get_first_match_physical_node(). The rationale to have this helper
> not only redunction of the lines of code, but improving the robustness
> by properly handling the reference counters on the error paths.

After rebasing on top of the latest code base (with Hans' patches included) I
checked the users of similar code flow and found that there is no sense to
provide this helper now. It's only one user for this API as is, otherwise it
needs an access to struct acpi_device, which the proposed API doesn't provide.

Hence, self-NAK.

--
With Best Regards,
Andy Shevchenko