Re: [PATCH] net: qrtr: free memory on error path in radix_tree_insert()

From: Simon Horman
Date: Wed Jan 25 2023 - 10:04:35 EST


On Wed, Jan 25, 2023 at 04:48:31PM +0300, Natalia Petrova wrote:
> Function radix_tree_insert() returns errors if the node hasn't
> been initialized and added to the tree.
>
> "kfree(node)" and return value "NULL" of node_get() help
> to avoid using unclear node in other calls.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace")
> Signed-off-by: Natalia Petrova <n.petrova@xxxxxxxxxx>

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>