Re: [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls

From: Liam R. Howlett
Date: Wed Jan 25 2023 - 08:53:50 EST


* Sven Schnelle <svens@xxxxxxxxxxxxx> [230125 06:00]:
> Hi Liam,
>
> "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx> writes:
>
> > From: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>
> >
> > Pass through the vma iterator to do_vmi_munmap() to handle the iterator
> > state internally
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> > ---
> > ipc/shm.c | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
>
> git bisect says this breaks the shm* testcase in ltp on (at least) s390:
>
> # ./test.sh
> tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s
> shmat01.c:124: TPASS: shmat() succeeded to attach NULL address
> shmat01.c:92: TFAIL: shmat() failed: EINVAL (22)
> shmat01.c:92: TFAIL: shmat() failed: EINVAL (22)
> shmat01.c:92: TFAIL: shmat() failed: EINVAL (22)
>
> Summary:
> passed 1
> failed 3
> broken 0
> skipped 0
> warnings 0
>
> #
>
> Can you take a look? Thanks!
>
> reverting the above commit fixes the issue.

Thanks for testing this and letting me know.

I'll have a look.

Regards,
Liam