Re: [PATCH] umh: fix UAF when the process is being killed

[Luis Chamberlain]

On Fri, Jan 13, 2023 at 01:42:05PM +0800, Schspa Shi wrote:
> 
> Luis Chamberlain <mcgrof@xxxxxxxxxx> writes:
> 
> > On Thu, Dec 22, 2022 at 08:09:38PM +0800, Schspa Shi wrote:
> >> 
> >> Attaching the full test program in case anyone wants to add some
> >> comments.
> >
> > Good stuff.
> >
> > That looks like a kernel sefltest. So you can just add it as an
> > initial selftest for completion so lib/test_completion.c and extend
> > lib/Kconfig.debug for a new kconfig symbol for it, and then just add
> > a script on tools/testing/selftets/completion/ with a simple makefile
> > which references a script which just calls modprobe. You can look at
> > tools/testing/selftests/kmod/ for an example.
> 
> OK, but I want to know, is it enough to add only positive examples for
> the test items here? Do we need a reverse example to prove that the
> previous writing is wrong?

That would mean adding code which would cause a UAF, perhaps useful if
disabled by default.

> > But I still think you may want an SmPL Coccinelle grammer patch to hunt
> > down other users with this pattern. The beneefit is that then you can
> > use the same Coccinelle patch to also then *fix* the issue in other
> > places.
> >
> 
> Yes, I'm learning about SmPL, and I'll add this syntax patch later to
> find more problems.

Great thanks.

  Luis