Re: [PATCH v2 2/4] arm64: dts: qcom: sm6350: Add camera clock controller

[Bryan O'Donoghue]

On 24/01/2023 14:48, Luca Weiss wrote:
> On Fri Jan 20, 2023 at 5:49 PM CET, Bryan O'Donoghue wrote:
> > On 20/01/2023 13:13, Luca Weiss wrote:
> > > +		camcc: clock-controller@ad00000 {
> > > +			compatible = "qcom,sm6350-camcc";
> > > +			reg = <0 0x0ad00000 0 0x16000>;
> > > +			clocks = <&rpmhcc RPMH_CXO_CLK>;
> > > +			#clock-cells = <1>;
> > > +			#reset-cells = <1>;
> > > +			#power-domain-cells = <1>;
> > > +		};
> >
> > Should you include
> >
> > required-opps = <&rpmhpd_opp_low_svs>;
> >
> > ?
>
> I don't know, it works without. But doesn't this property not just
> affect power-domains? I haven't passed any here.

Should you have a TITAN_TOP pd though ?

---
bod