Re: [PATCH v4 6/6] arch_topology: Build cacheinfo from primary CPU

From: Sudeep Holla
Date: Tue Jan 24 2023 - 09:55:56 EST


On Tue, Jan 24, 2023 at 02:48:39PM +0000, Sudeep Holla wrote:
>
> Ah, that thread, I remember that :).
>
> I still need to understand how this is related to memory allocation.
> Pierre was suggesting(in private) if we need to keep fetch_cache_info()
> arch specific but I really don't want to go down that patch until I
> understand and there is no other option.
>
> Thanks for your time. I will try to recall boot flow and see if I can
> gather the reasoning for the seen behaviour.
>

OK, I must have atleast taken a look at the code before I replied.
smp_prepare_boot_cpu() is called quite early before page_alloc_init()
and mm_init()(in init_main.c) while smp_prepare_cpus() get called
quite late from kernel_init->kernel_init_freeable().

Geert, can you please try with the patch Conor pointed out and see if
that helps to fix the allocation failures[1]

--
Regards,
Sudeep

[1] https://lore.kernel.org/all/20230103035316.3841303-1-leyfoon.tan@xxxxxxxxxxxxxxxx/