Re: [PATCH v8 07/10] block: Switch to pinning pages.

From: David Howells
Date: Tue Jan 24 2023 - 09:49:16 EST


David Hildenbrand <david@xxxxxxxxxx> wrote:

> > +static inline void bio_set_cleanup_mode(struct bio *bio, struct iov_iter *iter)
> > +{
> > + unsigned int cleanup_mode = iov_iter_extract_mode(iter);
> > +
> > + if (cleanup_mode & FOLL_GET)
> > + bio_set_flag(bio, BIO_PAGE_REFFED);
> > + if (cleanup_mode & FOLL_PIN)
> > + bio_set_flag(bio, BIO_PAGE_PINNED);
>
> Can FOLL_GET ever happen?

Yes - unless patches 8 and 9 are merged. I had them as one, but Christoph
split them up.

David