Re: [PATCH v8 00/10] iov_iter: Improve page extraction (pin or just list)

From: David Hildenbrand
Date: Tue Jan 24 2023 - 08:36:06 EST


On 24.01.23 14:32, Christoph Hellwig wrote:
On Tue, Jan 24, 2023 at 02:22:36PM +0100, David Hildenbrand wrote:
Note that while these series coverts the two most commonly used
O_DIRECT implementations, there are various others ones that do not
pin the pages yet.

Thanks for the info ... I assume these are then for other filesystems,
right? (such that we could adjust the tests to exercise these as well)

Yes. There's the fs/direct-io.c code still used by a few block based
file systems, and then all the not block based file systems as well
(e.g. NFS, cifs).

... do we have a list (or is it easy to make one)? :)

fs/direct-io.c is easy, just grep for blockdev_direct_IO.

The others are more complicated to find, but a grep for
iov_iter_get_pages2 and iov_iter_get_pages_alloc2 in fs/ should be a
good approximation.

Right, iov_iter_get_pages2() includes vmsplice() that still needs love. Thanks!

--
Thanks,

David / dhildenb