Re: [PATCH 6/7] arm64: dts: Add ipq9574 SoC and AL02 board support

[Devi Priya]

On 1/24/2023 3:16 PM, Konrad Dybcio wrote:
> On 24.01.2023 08:19, Devi Priya wrote:
> > On 1/13/2023 7:50 PM, Krzysztof Kozlowski wrote:
> > > On 13/01/2023 14:29, Devi Priya wrote:
> > > > > > +
> > > > > > +    soc: soc@0 {
> > > > > > +        #address-cells = <1>;
> > > > > > +        #size-cells = <1>;
> > > > > > +        ranges = <0 0 0 0xffffffff>;
> > > > > > +        compatible = "simple-bus";
> > > > > > +
> > > > > > +        tlmm: pinctrl@1000000 {
> > > > > > +            compatible = "qcom,ipq9574-tlmm";
> > > > > > +            reg = <0x01000000 0x300000>;
> > > > > > +            interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > +            gpio-controller;
> > > > > > +            #gpio-cells = <2>;
> > > > > > +            gpio-ranges = <&tlmm 0 0 65>;
> > > > > > +            gpio-reserved-ranges = <59 1>;
> > > > >
> > > > > Hm, why reserved ranges are in SoC?
> > > > As the gpio is forbidden on all ipq9574 boards, we have added it in SoC
> > >
> > > Why it is forbidden on all boards? I guess it depends on the firmware
> > > and this can differ, can't it?
> > This GPIO is protected and used by the TZ firmware and is forbidden on all the boards & firmware
> If it's protected on *all* boards and *all* firmwares (for any
> good reason that you probably have internally), perhaps it
> would be better to describe it in the .c driver.. wdyt?
Sure, okay. Will add the gpio to reserved_gpios entry in the pinctrl driver
> Konrad
> > > Best regards,
> > > Krzysztof
> > Regards,
> > Devi Priya