Re: BTF, pahole and static functions (was Re: [PATCH] libbpf: resolve kernel function name optimization for kprobe)

[Alexei Starovoitov]

On Mon, Jan 23, 2023 at 11:18 PM Yonghong Song <yhs@xxxxxxxx> wrote:
site.
> >>> So perhaps the best approach is to eliminate such inconsistent static
> >>> function descriptions? The actual amount is small, ~100 functions.
> >>
> >> Removing these inconsistent static functions could be a simpler
> >> approach.
> >
> > I took that approach with
> >
> > https://github.com/acmel/dwarves/commit/80eaecdb00b3d79becc2133b854593277093b115
> >
> > Static functions with inconsistent prototypes are left out of
> > BTF encoding. Given that the numbers here are pretty low (around
> > 100 or so, not including .isra functions which have inconsistent
> > prototypes due to optimizations), that seems to be the simplest
> > solution for now.
>
> Yes, I am okay with this approach. This will prevent user mistaking
> kprobe a wrong function and this is what we want for now.

Let's proceed with the fix first and then discuss improvements on top.